Fix gzip handling for HEAD requests in JdkClientHttpRequest (Issue #35966) #35968
+77
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
…ring-projects#35966) Skip gzip decompression when the response has Content-Length: 0 or HEAD method, preventing GZIPInputStream errors on empty bodies. Add test ensuring HEAD + gzip + empty body does not throw. Signed-off-by: AtharvUrunkar <[email protected]>
AtharvUrunkar
force-pushed
the
fix-35966-head-gzip
branch
from
dcc5498 to
3647c46
Compare
Member
|
Thanks for the proposal @AtharvUrunkar but I went with a different approach in 12c3dc0. Cheers! |
bclozel
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where making a HEAD request through Spring’s RestClient fails when the response contains:
Content-Encoding: gzip
An empty body (Content-Length: 0)
Previously, Spring attempted to wrap the empty body in a GZIPInputStream, causing an exception.
Fix implemented
Skip gzip/deflate decompression when:
The HTTP method is HEAD
OR the response declares Content-Length: 0
This prevents GZIPInputStream from being created for empty bodies.
Tests
Added a new test:
headRequestWithGzipContentEncodingShouldNotFail
This test verifies that gzip headers on a HEAD response with an empty body no longer cause exceptions.
Linked issue
Fixes: https://github.com/spring-projects/spring-framework/issues/35966